Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754485AbZGPLqk (ORCPT ); Thu, 16 Jul 2009 07:46:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752085AbZGPLqj (ORCPT ); Thu, 16 Jul 2009 07:46:39 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:39866 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751913AbZGPLqi (ORCPT ); Thu, 16 Jul 2009 07:46:38 -0400 X-Envelope-From: stefanr@s5r6.in-berlin.de Message-ID: <4A5F12FB.2050302@s5r6.in-berlin.de> Date: Thu, 16 Jul 2009 13:46:03 +0200 From: Stefan Richter User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.22) Gecko/20090630 SeaMonkey/1.1.17 MIME-Version: 1.0 To: subrata@linux.vnet.ibm.com CC: Artem Bityutskiy , linux-mtd@lists.infradead.org, Adrian Hunter , Sachin P Sant , David Howells , Balbir Singh , LKML Subject: Re: [PATCH 02/06] Fix compilation warning for fs/ubifs/commit.c References: <20090715021901.4112.45973.sendpatchset@subratamodak.linux.ibm.com> <1247640750.11353.6.camel@localhost.localdomain> <4A5E1D1A.3090705@s5r6.in-berlin.de> <1247738232.11353.90.camel@localhost.localdomain> <1247742274.5572.8.camel@subratamodak.linux.ibm.com> In-Reply-To: <1247742274.5572.8.camel@subratamodak.linux.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1022 Lines: 27 Subrata Modak wrote: >> Well, I just thought this type of warnings and way of fixing is very >> standard because I saw many similar fixes all over the place. > > Correct. There has been other warning fixes i have sent to LKML, where i > have tweaked the code to fix the compilation, but, code tweaking may not > be possible in this case. Wrong goal. The goal of a patch should be to improve the code. To remove false-positive warnings from compilation can only be a secondary goal. (See my other post.) BTW, which compiler do you use? I quickly enabled ubifs here, first without and then with its various sub-uptions, but didn't get a warning here with "gcc (Gentoo 4.3.2-r3 p1.6, pie-10.1.5) 4.3.2". -- Stefan Richter -=====-==--= -=== =---- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/