Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757288AbZGPNzP (ORCPT ); Thu, 16 Jul 2009 09:55:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757111AbZGPNzO (ORCPT ); Thu, 16 Jul 2009 09:55:14 -0400 Received: from smtp3.ultrahosting.com ([74.213.175.254]:33304 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755619AbZGPNzN (ORCPT ); Thu, 16 Jul 2009 09:55:13 -0400 Date: Thu, 16 Jul 2009 09:54:49 -0400 (EDT) From: Christoph Lameter X-X-Sender: cl@gentwo.org To: KOSAKI Motohiro cc: Johannes Weiner , Mel Gorman , Andrew Morton , Maxim Levitsky , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Lee Schermerhorn , Pekka Enberg , Jiri Slaby Subject: Re: [PATCH] mm: Warn once when a page is freed with PG_mlocked set V2 In-Reply-To: <20090716163537.9D3D.A69D9226@jp.fujitsu.com> Message-ID: References: <20090715220445.GA1823@cmpxchg.org> <20090716163537.9D3D.A69D9226@jp.fujitsu.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 599 Lines: 15 On Thu, 16 Jul 2009, KOSAKI Motohiro wrote: > I like this patch. but can you please separate two following patches? > - introduce __TESTCLEARFLAG() > - non-atomic test-clear of PG_mlocked on free That would mean introducing the macro without any use case? It is fine the way it is I think. Reviewed-by: Christoph Lameter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/