Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757567AbZGPOjj (ORCPT ); Thu, 16 Jul 2009 10:39:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757544AbZGPOjj (ORCPT ); Thu, 16 Jul 2009 10:39:39 -0400 Received: from smtp3.ultrahosting.com ([74.213.175.254]:40144 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757510AbZGPOji (ORCPT ); Thu, 16 Jul 2009 10:39:38 -0400 Date: Thu, 16 Jul 2009 10:39:17 -0400 (EDT) From: Christoph Lameter X-X-Sender: cl@gentwo.org To: Peter Zijlstra cc: Wu Fengguang , KOSAKI Motohiro , Minchan Kim , Johannes Weiner , David Howells , "riel@redhat.com" , Andrew Morton , LKML , "tytso@mit.edu" , "linux-mm@kvack.org" , "elladan@eskimo.com" , "npiggin@suse.de" , "Barnes, Jesse" Subject: Re: [PATCH] mm: count only reclaimable lru pages In-Reply-To: <1247754491.6586.23.camel@laptop> Message-ID: References: <20090716133454.GA20550@localhost> <20090716142533.GA27165@localhost> <1247754491.6586.23.camel@laptop> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 832 Lines: 21 On Thu, 16 Jul 2009, Peter Zijlstra wrote: > > What would you suggest? In fact I'm not totally comfortable with it. > > Maybe it would be safer to simply stick with the old _lru_pages > > naming? > > Nah, I like the reclaimable name, these pages are at least potentially > reclaimable. > > lru_pages() is definately not correct anymore since you exclude the > unevictable and possibly the anon pages. Well lets at least add a comment at the beginning of the functions explaining that these are potentially reclaimable and list some of the types of pages that may not be reclaimable. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/