From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH] mm: Warn once when a page is freed with PG_mlocked set V2
Cc: kosaki.motohiro@jp.fujitsu.com,
       Christoph Lameter <cl@linux-foundation.org>, Mel Gorman <mel@csn.ul.ie>,
       Andrew Morton <akpm@linux-foundation.org>,
       Maxim Levitsky <maximlevitsky@gmail.com>, linux-kernel@vger.kernel.org,
       linux-mm@kvack.org, Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
       Pekka Enberg <penberg@cs.helsinki.fi>, Jiri Slaby <jirislaby@gmail.com>
In-Reply-To: <20090716160139.GB1883@cmpxchg.org>
References: <alpine.DEB.1.10.0907160949470.32382@gentwo.org> <20090716160139.GB1883@cmpxchg.org>
Message-Id: <20090717091653.A909.A69D9226@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Date: Fri, 17 Jul 2009 09:17:43 +0900 (JST)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 957
Lines: 27

> On Thu, Jul 16, 2009 at 09:54:49AM -0400, Christoph Lameter wrote:
> > On Thu, 16 Jul 2009, KOSAKI Motohiro wrote:
> > 
> > > I like this patch. but can you please separate two following patches?
> > >   - introduce __TESTCLEARFLAG()
> > >   - non-atomic test-clear of PG_mlocked on free
> > 
> > That would mean introducing the macro without any use case? It is fine the
> > way it is I think.
> 
> Yeah, it's borderline.  In any case, I have the split version here as
> well.  Andrew, you choose :)
> 
> > Reviewed-by: Christoph Lameter <cl@linux-foundation.org>
> 
> Thanks,

OK, I can agree with Christoph. you don't need change the patch.

	Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/