Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964841AbZGQPo7 (ORCPT ); Fri, 17 Jul 2009 11:44:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964831AbZGQPo6 (ORCPT ); Fri, 17 Jul 2009 11:44:58 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:35015 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964823AbZGQPo5 (ORCPT ); Fri, 17 Jul 2009 11:44:57 -0400 Date: Fri, 17 Jul 2009 08:44:30 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Peter Zijlstra cc: David Miller , tglx@linutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kaber@trash.net Subject: Re: [patch 1/3] net: serialize hrtimer callback in sched_cbq In-Reply-To: <1247832892.15751.35.camel@twins> Message-ID: References: <20090709215606.526259917@linutronix.de> <20090712.135555.207096388.davem@davemloft.net> <20090714.090055.56906831.davem@davemloft.net> <1247588890.7500.186.camel@twins> <1247832892.15751.35.camel@twins> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1137 Lines: 31 On Fri, 17 Jul 2009, Peter Zijlstra wrote: > > How would something like the below work for people? This looks saner. It was the insanity of having the core timer code know about different modes that caused all the sily problems. Having a separate abstraction layer for "I want to get a softirq timeout" sounds fine, as long as the timer code itself never cares. That said, I don't think this shoud be a "hrtimer" issue (reflected in your naming and include file choice). I think this is a softirq or tasklet (or whatever) issue, and should be named that way. Why should the timer code (and header files) care about how you can use tasklets with them? It shouldn't. The timers should be seen as the really low-level critical code, and the timer code should never need to know about softirq's or tasklets or whatever. So I think you shouldmove it to kernel/softirq.c. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/