Date: Fri, 17 Jul 2009 18:28:19 -0700
From: Chris Wright <chrisw@sous-sol.org>
To: Sage Weil <sage@newdream.net>
Cc: Andi Kleen <andi@firstfloor.org>, linux-fsdevel@vger.kernel.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/20] ceph: Ceph distributed file system client v0.10
Message-ID: <20090718012819.GE8150@sequoia.sous-sol.org>
References: <1247693090-27796-1-git-send-email-sage@newdream.net> <87hbxcx182.fsf@basil.nowhere.org> <Pine.LNX.4.64.0907161004080.8026@cobra.newdream.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.64.0907161004080.8026@cobra.newdream.net>
User-Agent: Mutt/1.5.19 (2009-01-05)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 705
Lines: 17

* Sage Weil (sage@newdream.net) wrote:
> I don't always verify that things like element counts are "sane", though, 
> so there's currently the possibility of trying to allocate large chunks of 
> memory.

There's also the potential of allocating a small amount of memory w/ a
large element count if you overflow on multiply.  You should definitely
protect against this if you have such code in ceph client (kcalloc has
simple example defense).

thanks,
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/