Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753304AbZGTL77 (ORCPT ); Mon, 20 Jul 2009 07:59:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753088AbZGTL76 (ORCPT ); Mon, 20 Jul 2009 07:59:58 -0400 Received: from casper.infradead.org ([85.118.1.10]:43222 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753066AbZGTL76 (ORCPT ); Mon, 20 Jul 2009 07:59:58 -0400 Subject: Re: [PATCH] kbuild: save ARCH & CROSS_COMPILE when building a kernel From: Peter Zijlstra To: Sam Ravnborg Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20090720115134.GA6517@merkur.ravnborg.org> References: <20090720100157.GA6467@merkur.ravnborg.org> <1248086059.15751.8405.camel@twins> <20090720115134.GA6517@merkur.ravnborg.org> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Mon, 20 Jul 2009 14:00:43 +0200 Message-Id: <1248091243.15751.8550.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 858 Lines: 16 On Mon, 2009-07-20 at 13:51 +0200, Sam Ravnborg wrote: > -if [ -x ~/bin/${CROSS_COMPILE}installkernel ]; then exec ~/bin/${CROSS_COMPILE}installkernel "$@"; fi > -if [ -x /sbin/${CROSS_COMPILE}installkernel ]; then exec /sbin/${CROSS_COMPILE}installkernel "$@"; fi > +for INSTALL in ~/bin/${CROSS_COMPILE} /sbin/${CROSS_COMPILE} ~/bin /sbin/; do > + if [ -x ${INSTALL}installkernel ]; then > + exec ${INSTALL}installkernel "$@" > + fi > +done Won't that still get upset if CROSS_COMPILE has whitespace in it, which would form weird filenames etc.. or worse, it might match ~/bin/distcc -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/