Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752014AbZGTP1W (ORCPT ); Mon, 20 Jul 2009 11:27:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751537AbZGTP1U (ORCPT ); Mon, 20 Jul 2009 11:27:20 -0400 Received: from smtp3.ultrahosting.com ([74.213.175.254]:48110 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751489AbZGTP1U (ORCPT ); Mon, 20 Jul 2009 11:27:20 -0400 Date: Mon, 20 Jul 2009 11:27:08 -0400 (EDT) From: Christoph Lameter X-X-Sender: cl@gentwo.org To: KOSAKI Motohiro cc: LKML , linux-mm , Andrew Morton , Wu Fengguang , Rik van Riel , Minchan Kim Subject: Re: [PATCH 3/3] add isolate pages vmstat In-Reply-To: <20090720143838.7481.A69D9226@jp.fujitsu.com> Message-ID: References: <20090717085821.A900.A69D9226@jp.fujitsu.com> <20090720143838.7481.A69D9226@jp.fujitsu.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 912 Lines: 23 On Mon, 20 Jul 2009, KOSAKI Motohiro wrote: > > On Fri, 17 Jul 2009, KOSAKI Motohiro wrote: > > > > > > Why do a separate pass over all the migrates pages? Can you add the > > > > _inc_xx somewhere after the page was isolated from the lru by calling > > > > try_to_unmap()? > > > > > > calling try_to_unmap()? the pages are isolated before calling migrate_pages(). > > > migrate_pages() have multiple caller. then I put this __inc_xx into top of > > > migrate_pages(). > > > > Then put the inc_xxx's where the pages are isolated. > > Is there any benefit? Why do we need sprinkle __inc_xx to many place? Its only needed in one place where the pages are isolated. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/