Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752817AbZGTQXN (ORCPT ); Mon, 20 Jul 2009 12:23:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752602AbZGTQXN (ORCPT ); Mon, 20 Jul 2009 12:23:13 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:36109 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752580AbZGTQXM (ORCPT ); Mon, 20 Jul 2009 12:23:12 -0400 Date: Tue, 21 Jul 2009 01:22:25 +0900 (JST) X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: Christoph Lameter Subject: Re: [PATCH 3/3] add isolate pages vmstat Cc: kosaki.motohiro@jp.fujitsu.com, LKML , linux-mm , Andrew Morton , Wu Fengguang , Rik van Riel , Minchan Kim In-Reply-To: References: <20090720143838.7481.A69D9226@jp.fujitsu.com> Message-Id: <20090721012054.AF7B.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1046 Lines: 29 > On Mon, 20 Jul 2009, KOSAKI Motohiro wrote: > > > > On Fri, 17 Jul 2009, KOSAKI Motohiro wrote: > > > > > > > > Why do a separate pass over all the migrates pages? Can you add the > > > > > _inc_xx somewhere after the page was isolated from the lru by calling > > > > > try_to_unmap()? > > > > > > > > calling try_to_unmap()? the pages are isolated before calling migrate_pages(). > > > > migrate_pages() have multiple caller. then I put this __inc_xx into top of > > > > migrate_pages(). > > > > > > Then put the inc_xxx's where the pages are isolated. > > > > Is there any benefit? Why do we need sprinkle __inc_xx to many place? > > Its only needed in one place where the pages are isolated. Umm.. I haven't understand this benefit. but I guess I can do that. I'll think it later deeply. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/