Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753479AbZGTShW (ORCPT ); Mon, 20 Jul 2009 14:37:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752840AbZGTShU (ORCPT ); Mon, 20 Jul 2009 14:37:20 -0400 Received: from buzzloop.caiaq.de ([212.112.241.133]:36834 "EHLO buzzloop.caiaq.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751629AbZGTShU (ORCPT ); Mon, 20 Jul 2009 14:37:20 -0400 Date: Mon, 20 Jul 2009 20:37:11 +0200 From: Daniel Mack To: Anton Vorontsov Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Ian Molton , Anton Vorontsov , Matt Reimer Subject: Re: [PATCH 1/3] pda-power: add set_charged functionaltity Message-ID: <20090720183711.GF19257@buzzloop.caiaq.de> References: <1247759044-4747-1-git-send-email-daniel@caiaq.de> <20090720182752.GA20602@oksana.dev.rtsoft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090720182752.GA20602@oksana.dev.rtsoft.ru> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2267 Lines: 55 On Mon, Jul 20, 2009 at 10:27:52PM +0400, Anton Vorontsov wrote: > On Thu, Jul 16, 2009 at 05:44:02PM +0200, Daniel Mack wrote: > > This adds a function to let the power supply core know that the battery > > is fully charged now. This can be done by watching a GPIO line, for > > example. > > > > Some battery drivers might need that information to calibrate > > themselves. > > > > Signed-off-by: Daniel Mack > > Cc: Ian Molton > > Cc: Anton Vorontsov > > Cc: Matt Reimer > > --- > > drivers/power/power_supply_core.c | 16 ++++++++++++++++ > > include/linux/power_supply.h | 3 +++ > > The patch is missing pda_power.c part? Erm, does it? What would you expect it to do in there? > > #if defined(CONFIG_POWER_SUPPLY) || defined(CONFIG_POWER_SUPPLY_MODULE) > > extern int power_supply_is_system_supplied(void); > > +extern void power_supply_set_battery_charged(void); > > I don't quite like this interface. Note that system might want > to know if it's supplied (hence global is_system_supplied(void) call), > but having set_battery_charged(void) interface makes little sense > (well, it makes sense for small embedded systems that have just > one battery and one charger)... > > There is a supplied_to psy field that might help you there... Hmm. I thought about that too, but didn't find a way to access the single members of the pda-power device and find the right one to access. They're registered on a string base and matched magically once the battery monitor is probed when found on the one-wire bus. Any proposal how an interface could look like that does that? All I need is a way to pass this information from my platform code down to the battery driver. > The cleanup patch looks OK though, I'll apply it. Thanks. What about the one adding support for the bootstrapping of the current_accum value? I've sent that inline as a reply to the other patch series (4/4) last week (which was probably not a good idea). Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/