Date: Mon, 20 Jul 2009 12:57:54 -0700
From: Greg KH <gregkh@suse.de>
To: Andi Kleen <andi@firstfloor.org>
Cc: Dave Jones <davej@redhat.com>, linux-kernel@vger.kernel.org,
       devel@driverdev.osuosl.org, virtualization@lists.osdl.org,
       Hank Janssen <hjanssen@microsoft.com>
Subject: Re: [patch 00/54] [Announce] Microsoft Hyper-V drivers for Linux
Message-ID: <20090720195754.GB30483@suse.de>
References: <20090720160025.GA20249@kroah.com>
 <20090720162810.GA22102@kroah.com>
 <20090720165941.GA15660@redhat.com>
 <20090720170345.GA23990@suse.de>
 <871vob4047.fsf@basil.nowhere.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <871vob4047.fsf@basil.nowhere.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1162
Lines: 31

On Mon, Jul 20, 2009 at 09:37:12PM +0200, Andi Kleen wrote:
> Greg KH <gregkh@suse.de> writes:
> >
> > It's the "normal" way of cleaning up code.  Start with a known-working
> > piece of stuff, and incrementally clean it up. 
> 
> I have to agree with David. This is essentially unreviewable
> in the original state. It would be good if you could
> do all the obvious cleanups first and then post a consolidated
> series.
> 
> Most "obvious" cleanups should not change the binary, so
> you can easily check they are correct by comparing the assembler
> code.

Unfortunatly, some of these cleanups do change the binary, as they are
removing wrapper functions.

Anyway, I agree, for a "proper" review, I will show the final, cleaned
up version, like normal.  But we aren't there just yet, that is why this
code is going to live in the staging tree for a while.  Give us some
time to get it fixed up.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/