Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754014AbZGTVMT (ORCPT ); Mon, 20 Jul 2009 17:12:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753960AbZGTVMR (ORCPT ); Mon, 20 Jul 2009 17:12:17 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:42789 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753876AbZGTVMO (ORCPT ); Mon, 20 Jul 2009 17:12:14 -0400 Date: Mon, 20 Jul 2009 14:11:50 -0700 From: Andrew Morton To: Amerigo Wang Cc: linux-kernel@vger.kernel.org, heiko.carstens@de.ibm.com, amwang@redhat.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, mszeredi@suse.cz Subject: Re: [Patch] pipe: use file_update_time() when hold i_mutex Message-Id: <20090720141150.e9d081ca.akpm@linux-foundation.org> In-Reply-To: <20090706053745.6338.50777.sendpatchset@localhost.localdomain> References: <20090706053745.6338.50777.sendpatchset@localhost.localdomain> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 475 Lines: 14 On Mon, 6 Jul 2009 01:35:30 -0400 Amerigo Wang wrote: > > file_update_time() should be called with i_mutex held, > move it before mutex_unlock(). > Why do you believe that file_update_time() needs i_mutex? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/