Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754034AbZGTWTX (ORCPT ); Mon, 20 Jul 2009 18:19:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753428AbZGTWTW (ORCPT ); Mon, 20 Jul 2009 18:19:22 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:39780 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751524AbZGTWTV (ORCPT ); Mon, 20 Jul 2009 18:19:21 -0400 Date: Tue, 21 Jul 2009 00:19:15 +0200 From: Pavel Machek To: reinette chatre Cc: kernel list , Trivial patch monkey Subject: Re: iwl3945: fix LED config option Message-ID: <20090720221914.GB28907@elf.ucw.cz> References: <20090619222431.GA2398@elf.ucw.cz> <1246298908.17896.391.camel@rc-desk> <20090709093859.GA10001@elf.ucw.cz> <1247153986.17896.1233.camel@rc-desk> <20090718102030.GA2040@elf.ucw.cz> <1248122730.17896.2582.camel@rc-desk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1248122730.17896.2582.camel@rc-desk> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1482 Lines: 34 > > diff --git a/drivers/net/wireless/iwlwifi/Kconfig b/drivers/net/wireless/iwlwifi/Kconfig > > index e092af0..95d9aa5 100644 > > --- a/drivers/net/wireless/iwlwifi/Kconfig > > +++ b/drivers/net/wireless/iwlwifi/Kconfig > > @@ -9,6 +9,10 @@ config IWLWIFI > > config IWLWIFI_LEDS > > bool "Enable LED support in iwlagn and iwl3945 drivers" > > depends on IWLWIFI > > + default y > > This is reasonable. > > > + ---help--- > > + Useful to get Wifi LED working at least on Thinkpad notebooks. > > I do not think this says more than what we already have. I actually > think noting something about a particular platform will increase > confusion (as in "so where is the option if I have an acer laptop?") > because this option is needed to get LED support on all platforms. I do > think what is currently written is sufficient, but if you insist on > having some text there I think it should be simpler. Something like > "Select this if you want LED support." Sounds good. (I really believe it should have _some_ text). Will you just modify/apply the patch, or should I resent? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/