Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754572AbZGUCOP (ORCPT ); Mon, 20 Jul 2009 22:14:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752795AbZGUCOO (ORCPT ); Mon, 20 Jul 2009 22:14:14 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.125]:36253 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751805AbZGUCON (ORCPT ); Mon, 20 Jul 2009 22:14:13 -0400 Date: Mon, 20 Jul 2009 22:14:11 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Li Zefan cc: Frederic Weisbecker , Ingo Molnar , Tom Zanussi , LKML Subject: Re: [PATCH v2] tracing/filters: Improve subsystem filter In-Reply-To: <4A651DF2.3060403@cn.fujitsu.com> Message-ID: References: <4A63D485.7030703@cn.fujitsu.com> <4A651907.1090805@cn.fujitsu.com> <4A651DF2.3060403@cn.fujitsu.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 995 Lines: 30 On Tue, 21 Jul 2009, Li Zefan wrote: > >> 2: > >> # cat filter > >> irq == not_num > >> ^ > >> parse_error: Couldn't find or set field in one of a subsystem's events > > > > This looks good, BUT, it is too much. If you want to implement an error > > message like the above, it should probably be a "pr_info()" thing. > > > > Yeah, I think it's too much too, but that's exactly what we have. > And I posted a patch to remove those error messages, but Tom and > Frederic didn't seem to like it: > > http://lkml.org/lkml/2009/6/17/89 > Ah, I forgot about that thread. Well, Frederic did mention making a "filter_error" file. That sounds like a good solution to me. But I have no strong opinions on this one way or another. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/