Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754745AbZGUDCI (ORCPT ); Mon, 20 Jul 2009 23:02:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754564AbZGUDCI (ORCPT ); Mon, 20 Jul 2009 23:02:08 -0400 Received: from mga11.intel.com ([192.55.52.93]:8312 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754398AbZGUDCH (ORCPT ); Mon, 20 Jul 2009 23:02:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.43,238,1246863600"; d="scan'208";a="476576467" Subject: Re: iwl3945: fix LED config option From: reinette chatre To: Pavel Machek Cc: kernel list , Trivial patch monkey In-Reply-To: <20090720221914.GB28907@elf.ucw.cz> References: <20090619222431.GA2398@elf.ucw.cz> <1246298908.17896.391.camel@rc-desk> <20090709093859.GA10001@elf.ucw.cz> <1247153986.17896.1233.camel@rc-desk> <20090718102030.GA2040@elf.ucw.cz> <1248122730.17896.2582.camel@rc-desk> <20090720221914.GB28907@elf.ucw.cz> Content-Type: text/plain Date: Mon, 20 Jul 2009 20:02:06 -0700 Message-Id: <1248145326.17896.2605.camel@rc-desk> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1551 Lines: 40 Hi Pavel, On Mon, 2009-07-20 at 15:19 -0700, Pavel Machek wrote: > > > diff --git a/drivers/net/wireless/iwlwifi/Kconfig b/drivers/net/wireless/iwlwifi/Kconfig > > > index e092af0..95d9aa5 100644 > > > --- a/drivers/net/wireless/iwlwifi/Kconfig > > > +++ b/drivers/net/wireless/iwlwifi/Kconfig > > > @@ -9,6 +9,10 @@ config IWLWIFI > > > config IWLWIFI_LEDS > > > bool "Enable LED support in iwlagn and iwl3945 drivers" > > > depends on IWLWIFI > > > + default y > > > > This is reasonable. > > > > > + ---help--- > > > + Useful to get Wifi LED working at least on Thinkpad notebooks. > > > > I do not think this says more than what we already have. I actually > > think noting something about a particular platform will increase > > confusion (as in "so where is the option if I have an acer laptop?") > > because this option is needed to get LED support on all platforms. I do > > think what is currently written is sufficient, but if you insist on > > having some text there I think it should be simpler. Something like > > "Select this if you want LED support." > > Sounds good. (I really believe it should have _some_ text). Will you > just modify/apply the patch, or should I resent? Sure, I can take this patch and will send it through our usual route (via linux-wireless). Reinette -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/