Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752810AbZGUFZG (ORCPT ); Tue, 21 Jul 2009 01:25:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752398AbZGUFZE (ORCPT ); Tue, 21 Jul 2009 01:25:04 -0400 Received: from ns1.siteground211.com ([209.62.36.12]:36904 "EHLO serv01.siteground211.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751895AbZGUFZD (ORCPT ); Tue, 21 Jul 2009 01:25:03 -0400 Date: Tue, 21 Jul 2009 08:24:48 +0300 From: Felipe Balbi To: "Shilimkar, Santosh" Cc: "me@felipebalbi.com" , "Krishnamoorthy, Balaji T" , "linux-kernel@vger.kernel.org" , "tony@atomide.com" , "khilman@deeprootsystems.com" , "david-b@pacbell.net" , "linux-omap@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "sameo@openedhand.com" , "wim@iguana.be" , "timo.t.kokkonen@nokia.com" , "ben-linux@fluff.org" , "lrg@slimlogic.co.uk" , "broonie@opensource.wolfsonmicro.com" , "Nayak, Rajendra" Subject: Re: [PATCH 1/4] ARM: OMAP: Rename twl4030* driver files to enable re-use Message-ID: <20090721052447.GA13013@gandalf> Reply-To: me@felipebalbi.com References: <1248096671-13828-1-git-send-email-balajitk@ti.com> <20090720185253.GA7984@gandalf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - serv01.siteground211.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - felipebalbi.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1007 Lines: 21 hi, On Tue, Jul 21, 2009 at 10:01:06AM +0530, Shilimkar, Santosh wrote: > > So IMO, renaming the files is unnecessary. > Well tps* are just catalog names of the twl4* family. So you can keep adding whatever names there as long it's a same IC. > > Perhaps you look in hurry to comment about this. Please look at the intention of these patches. TWL6030 has PM IC similar to TWL4030 with bit different interrupt management. Audio IC is a separate one as compared to combined in case of TWL4030. > > If it allows code re-use by renaming files, it should be good. Isn't it ? What I'm trying to say is you can re-use the code even without renaming those files, just add twl6030-irq and use some sort of runtime check to use one or other irq mechanism. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/