Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753376AbZGUFe3 (ORCPT ); Tue, 21 Jul 2009 01:34:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752802AbZGUFe2 (ORCPT ); Tue, 21 Jul 2009 01:34:28 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:44956 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752213AbZGUFe0 convert rfc822-to-8bit (ORCPT ); Tue, 21 Jul 2009 01:34:26 -0400 From: "Shilimkar, Santosh" To: "me@felipebalbi.com" CC: "Krishnamoorthy, Balaji T" , "linux-kernel@vger.kernel.org" , "tony@atomide.com" , "khilman@deeprootsystems.com" , "david-b@pacbell.net" , "linux-omap@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "sameo@openedhand.com" , "wim@iguana.be" , "timo.t.kokkonen@nokia.com" , "ben-linux@fluff.org" , "lrg@slimlogic.co.uk" , "broonie@opensource.wolfsonmicro.com" , "Nayak, Rajendra" Date: Tue, 21 Jul 2009 11:03:53 +0530 Subject: RE: [PATCH 1/4] ARM: OMAP: Rename twl4030* driver files to enable re-use Thread-Topic: [PATCH 1/4] ARM: OMAP: Rename twl4030* driver files to enable re-use Thread-Index: AcoJw59907n3Pl/1RPeR9IiKa0kO6gAABs3g Message-ID: References: <1248096671-13828-1-git-send-email-balajitk@ti.com> <20090720185253.GA7984@gandalf> <20090721052447.GA13013@gandalf> In-Reply-To: <20090721052447.GA13013@gandalf> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1999 Lines: 51 > -----Original Message----- > From: Felipe Balbi [mailto:me@felipebalbi.com] > Sent: Tuesday, July 21, 2009 10:55 AM > To: Shilimkar, Santosh > Cc: me@felipebalbi.com; Krishnamoorthy, Balaji T; > linux-kernel@vger.kernel.org; tony@atomide.com; > khilman@deeprootsystems.com; david-b@pacbell.net; > linux-omap@vger.kernel.org; linux-i2c@vger.kernel.org; > sameo@openedhand.com; wim@iguana.be; > timo.t.kokkonen@nokia.com; ben-linux@fluff.org; > lrg@slimlogic.co.uk; broonie@opensource.wolfsonmicro.com; > Nayak, Rajendra > Subject: Re: [PATCH 1/4] ARM: OMAP: Rename twl4030* driver > files to enable re-use > > hi, > > On Tue, Jul 21, 2009 at 10:01:06AM +0530, Shilimkar, Santosh wrote: > > > So IMO, renaming the files is unnecessary. > > Well tps* are just catalog names of the twl4* family. So > you can keep adding whatever names there as long it's a same IC. > > > > Perhaps you look in hurry to comment about this. Please > look at the intention of these patches. TWL6030 has PM IC > similar to TWL4030 with bit different interrupt management. > Audio IC is a separate one as compared to combined in case of TWL4030. > > > > If it allows code re-use by renaming files, it should be > good. Isn't it ? > > What I'm trying to say is you can re-use the code even > without renaming > those files, just add twl6030-irq and use some sort of > runtime check to > use one or other irq mechanism. We initially tried this but code is becoming ugly and not at all readable. In fact this was a short cut and would have saved us some time :) By renaming, we thought it can become a generic for further versions of TWL IC's and adding support to those would be cleaner. Let's get feedback from more people on the list Regards, Santosh-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/