Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753766AbZGUIsu (ORCPT ); Tue, 21 Jul 2009 04:48:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753057AbZGUIst (ORCPT ); Tue, 21 Jul 2009 04:48:49 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:52171 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751124AbZGUIss (ORCPT ); Tue, 21 Jul 2009 04:48:48 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Tue, 21 Jul 2009 17:46:59 +0900 From: KAMEZAWA Hiroyuki To: KAMEZAWA Hiroyuki Cc: Andrew Morton , ebiederm@xmission.com, xiyou.wangcong@gmail.com, tao.ma@oracle.com, linux-kernel@vger.kernel.org, adobriyan@gmail.com, mtk.manpages@gmail.com, y-goto@jp.fujitsu.com Subject: Re: [RESEND Patch] kcore: remove its pointless size Message-Id: <20090721174659.2c860ee4.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20090721110924.39a93078.kamezawa.hiroyu@jp.fujitsu.com> References: <20090613040958.GA2959@cr0> <2375c9f90906160829g3d605836yb4c5b9beeac50c5f@mail.gmail.com> <20090618030051.GA6133@cr0.nay.redhat.com> <20090618044055.GB6133@cr0.nay.redhat.com> <20090622085405.GA6499@cr0.nay.redhat.com> <20090630100850.GD5873@cr0.nay.redhat.com> <20090701144742.6ce3535b.akpm@linux-foundation.org> <20090701171249.004968e8.akpm@linux-foundation.org> <20090702094138.f86ead92.kamezawa.hiroyu@jp.fujitsu.com> <20090717152955.6585cbf9.akpm@linux-foundation.org> <20090721110924.39a93078.kamezawa.hiroyu@jp.fujitsu.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 2.5.0 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1542 Lines: 48 On Tue, 21 Jul 2009 11:09:24 +0900 KAMEZAWA Hiroyuki wrote: > On Fri, 17 Jul 2009 15:29:55 -0700 > Andrew Morton wrote: > > > On Thu, 2 Jul 2009 09:41:38 +0900 > > KAMEZAWA Hiroyuki wrote: > > I think I'm about to forget about the above issues. If everyone else > > does the same, they won't get addressed. Oh well. > > > > And I still need to decide whether > > kcore-fix-proc-kcores-statst_size.patch fixes things up sufficiently > > well to justify merging it. > > > > Hmm, I read fs/proc/kcore.c and feel followng, now. > > - kclist doesn't handle memory hole, then, it will never be "correct" size. > For example, arch/x86/mm/init.c calls kclist_add() as following > > 715 kclist_add(&kcore_vmalloc, (void *)VMALLOC_START, > 716 VMALLOC_END-VMALLOC_START); > > Wow, extremely big anyway. > > - Then, yes. Size of /proc/kcode is pointless. Anyway, what's important is > not "size", but ELF phder of kcore. > > To this patch, > Acked-by: KAMEZAWA Hiroyuki > Ah...BTW, if set size to be 0, %objdump -x /proc/kcore returns immediately because objdump finds size as 0. but readelf seems to work well. Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/