Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755384AbZGUL37 (ORCPT ); Tue, 21 Jul 2009 07:29:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755163AbZGUL37 (ORCPT ); Tue, 21 Jul 2009 07:29:59 -0400 Received: from one.firstfloor.org ([213.235.205.2]:58401 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754566AbZGUL36 (ORCPT ); Tue, 21 Jul 2009 07:29:58 -0400 To: KAMEZAWA Hiroyuki Cc: Andrew Morton , ebiederm@xmission.com, xiyou.wangcong@gmail.com, tao.ma@oracle.com, linux-kernel@vger.kernel.org, adobriyan@gmail.com, mtk.manpages@gmail.com, y-goto@jp.fujitsu.com Subject: Re: [RFC][PATCH 0/3] kcore: clean up and update ram information properly From: Andi Kleen References: <20090613040958.GA2959@cr0> <2375c9f90906160829g3d605836yb4c5b9beeac50c5f@mail.gmail.com> <20090618030051.GA6133@cr0.nay.redhat.com> <20090618044055.GB6133@cr0.nay.redhat.com> <20090622085405.GA6499@cr0.nay.redhat.com> <20090630100850.GD5873@cr0.nay.redhat.com> <20090701144742.6ce3535b.akpm@linux-foundation.org> <20090701171249.004968e8.akpm@linux-foundation.org> <20090702094138.f86ead92.kamezawa.hiroyu@jp.fujitsu.com> <20090717152955.6585cbf9.akpm@linux-foundation.org> <20090721183628.edbb7b99.kamezawa.hiroyu@jp.fujitsu.com> Date: Tue, 21 Jul 2009 13:29:57 +0200 In-Reply-To: <20090721183628.edbb7b99.kamezawa.hiroyu@jp.fujitsu.com> (KAMEZAWA Hiroyuki's message of "Tue, 21 Jul 2009 18:36:28 +0900") Message-ID: <873a8q2s0a.fsf@basil.nowhere.org> User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1285 Lines: 33 KAMEZAWA Hiroyuki writes: > Now, /proc/kcore is built on kclist information which is constructed at boot. > This kclist includes physical memory range information but not updated at > memory hotplug. And, this information tends to includes big memory hole. > > On the other hand, /proc/iomem includes all physical memory information as > "System RAM" and this is updated properly and kdump use this, IIUC. > (I hope all archtecuture stores necessary information...) > > This patch tries to build kclist for physical memory(direct map) on > /proc/iomem info. It's refreshed at open("/proc/kcore",) if necesasry. > > This is just a RFC. Any comments are welcome. > > [1/3] ... clean up kclist handling. > [2/3] ... clean up kclist_add() > [3/3] ... use /proc/iomem information for /proc/kcore. Great cleanup! Thanks. The only missing part that we still need is to also include the kallsyms information, then the core would be even more useful. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/