Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755516AbZGUPsl (ORCPT ); Tue, 21 Jul 2009 11:48:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755069AbZGUPsj (ORCPT ); Tue, 21 Jul 2009 11:48:39 -0400 Received: from iabervon.org ([66.92.72.58]:46569 "EHLO iabervon.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755480AbZGUPsj (ORCPT ); Tue, 21 Jul 2009 11:48:39 -0400 Date: Tue, 21 Jul 2009 11:48:37 -0400 (EDT) From: Daniel Barkalow To: Pavel Machek cc: apw@canonical.com, kernel list Subject: Re: checkpatch whitespace In-Reply-To: <20090721100113.GC4133@elf.ucw.cz> Message-ID: References: <20090721100113.GC4133@elf.ucw.cz> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1047 Lines: 24 On Tue, 21 Jul 2009, Pavel Machek wrote: > I don't think that a bit of trailing whitespace hurts that much (it is > very easy to create when fixing overly long lines, another checkpatch > complain), and at least akpm autofixes the whitespace, anyway, but... The problem with trailing whitespace in files is that future developers have to keep it the same while making changes in the area, or it'll add noise to their commits and patches. Fixing up a patch to stop removing trailing whitespace is even more of a pain than fixing a patch to stop adding it. > Would it be possible to add autofixing to checkpatch? Fixing > whitespace issues by hand is useless & boring task... Until checkpatch does it, "git apply" can be configured to auto-correct. -Daniel *This .sig left intentionally blank* -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/