Date: Tue, 21 Jul 2009 17:18:11 +0100
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Daniel Mack <daniel@caiaq.de>,
       Kernel development list <linux-kernel@vger.kernel.org>,
       USB list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] [usb-serial] fix Ooops on uplug
Message-ID: <20090721171811.278a2c62@lxorguk.ukuu.org.uk>
In-Reply-To: <Pine.LNX.4.44L0.0907211205420.2724-100000@iolanthe.rowland.org>
References: <20090721170055.10cce812@lxorguk.ukuu.org.uk>
	<Pine.LNX.4.44L0.0907211205420.2724-100000@iolanthe.rowland.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1045
Lines: 33

On Tue, 21 Jul 2009 12:11:39 -0400 (EDT)
Alan Stern <stern@rowland.harvard.edu> wrote:

> On Tue, 21 Jul 2009, Alan Cox wrote:
> 
> > > The problem is that freed resources are accessed, and that can lead to
> > > any kind of strange kernel faults from crashing to other subsequent
> > > errors.
> > > 
> > > Did you try my patch?
> 
> No.
> 
> > We've already established your patch is wrong. So trying it isn't at all
> > helpful.
> 
> I'll take your word for it.  It will take some time to figure out 
> exactly which buffers are getting used after they are freed, although 
> the most likely is the usb_serial_port structure itself.
> 
> Let you know what I find...

On the tty side if you look in tty_io.c there is a define

TTY_DEBUG_HANGUP

which exists especially for these sorts of events..

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/