Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755562AbZGUQoW (ORCPT ); Tue, 21 Jul 2009 12:44:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754551AbZGUQoT (ORCPT ); Tue, 21 Jul 2009 12:44:19 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:64875 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755129AbZGUQoR (ORCPT ); Tue, 21 Jul 2009 12:44:17 -0400 Date: Tue, 21 Jul 2009 12:44:15 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Ray Lee cc: Jason Baron , mingo@elte.hu, linux-kernel@vger.kernel.org, paulus@samba.org, a.p.zijlstra@chello.nl, fweisbec@gmail.com Subject: Re: [PATCH 2/2] perf_counter: detect debugfs location In-Reply-To: <2c0942db0907210926ra96ee33ke3e6ac8c57458be8@mail.gmail.com> Message-ID: References: <42fb2af3afccef87d78ca6dd86169ad180b63271.1248190728.git.jbaron@redhat.com> <2c0942db0907210926ra96ee33ke3e6ac8c57458be8@mail.gmail.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1048 Lines: 27 On Tue, 21 Jul 2009, Ray Lee wrote: > On Tue, Jul 21, 2009 at 9:20 AM, Jason Baron wrote: > > > > Search for the debugfs filesystem in /proc/mounts, but also allows the user to > > specify '--debugfs-dir=blah' or set the environment variable: 'PERF_DIR_DEBUGFS' > > > -static char default_debugfs_path[] = "/sys/kernel/debug/tracing/events"; > > There are server systems out there that run with thousands of mounts. > It would be kinder to the users of those systems (ie, faster perf > startup) if you only went rooting around /proc/mounts if opening the > default location failed. Well, those that have thousand of mounts could probably get away with setting PERF_DIR_DEBUGFS in /etc/profile. But, a simple stat("/sys/kernel/debug/tracing") should be easy enough. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/