DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=googlemail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=u5wpUAvbhHfFJSahfQHA+vMhJWyCbe0uy10Kaw6HX0NFga4wryZO2RLuRcAIY6ppPB
         8KS9cN/gup/b+IRx8U18EtL325U27nH7Us5R7sA/e59/bDUmH6Jjqb/KH8y77wcG9QOw
         hnMy/i77BO7gLT2lUp/zPhcOWmP5KVXuICdlo=
MIME-Version: 1.0
In-Reply-To: <20090721160333.96AA4D3D@kernel>
References: <20090721160333.96AA4D3D@kernel>
Date: Tue, 21 Jul 2009 18:57:50 +0200
Message-ID: <1158166a0907210957p6fb73ed7pc7f5bb9f9ad6eac2@mail.gmail.com>
Subject: Re: [RFC][PATCH] flexible array implementation
From: Denys Vlasenko <vda.linux@googlemail.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: akpm@linux-foundation.org, containers@lists.linux-foundation.org,
       bblum@google.com, linux-kernel@vger.kernel.org, menage@google.com
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 877
Lines: 26

On Tue, Jul 21, 2009 at 6:03 PM, Dave Hansen<dave@linux.vnet.ibm.com> wrote:
> +static inline struct flex_array_part *
> +__fa_get_part(struct flex_array *fa, int part_nr, gfp_t flags)
> +{
> + ? ? ? struct flex_array_part *part = NULL;
> + ? ? ? if (part_nr > __nr_part_ptrs())
> + ? ? ? ? ? ? ? return NULL;
> + ? ? ? part = fa->parts[part_nr];
> + ? ? ? if (!part) {
> + ? ? ? ? ? ? ? part = kmalloc(FLEX_ARRAY_PART_SIZE, flags);
> + ? ? ? ? ? ? ? if (!part)
> + ? ? ? ? ? ? ? ? ? ? ? return NULL;
> + ? ? ? ? ? ? ? fa->parts[part_nr] = part;
> + ? ? ? }
> + ? ? ? return part;
> +}

This is far too big to be an inline.

--
vda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/