Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754954AbZGUSBJ (ORCPT ); Tue, 21 Jul 2009 14:01:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752892AbZGUSBI (ORCPT ); Tue, 21 Jul 2009 14:01:08 -0400 Received: from mx2.redhat.com ([66.187.237.31]:36443 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751698AbZGUSBH (ORCPT ); Tue, 21 Jul 2009 14:01:07 -0400 Date: Tue, 21 Jul 2009 20:01:00 +0200 From: Andrea Arcangeli To: Rik van Riel Cc: Izik Eidus , akpm@linux-foundation.org, hugh.dickins@tiscali.co.uk, chrisw@redhat.com, avi@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nickpiggin@yahoo.com.au, Wu Fengguang Subject: Re: [PATCH 06/10] ksm: identify PageKsm pages Message-ID: <20090721180059.GG2239@random.random> References: <1247851850-4298-1-git-send-email-ieidus@redhat.com> <1247851850-4298-2-git-send-email-ieidus@redhat.com> <1247851850-4298-3-git-send-email-ieidus@redhat.com> <1247851850-4298-4-git-send-email-ieidus@redhat.com> <1247851850-4298-5-git-send-email-ieidus@redhat.com> <1247851850-4298-6-git-send-email-ieidus@redhat.com> <1247851850-4298-7-git-send-email-ieidus@redhat.com> <20090721175139.GE2239@random.random> <4A660101.3000307@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A660101.3000307@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 855 Lines: 19 On Tue, Jul 21, 2009 at 01:55:13PM -0400, Rik van Riel wrote: > I guess that if they are to remain unswappable, they > should go onto the unevictable list. They should indeed. Not urgent but it will optimize the vm (as in virtual memory) cpu load a bit. > Then again, I'm guessing this is all about to change > in not too much time :) That's my point, current implementation of PageKsm don't seem to last long, and if we keep logic the same it'll likely happen soon that PageKsm != PageAnon on a Ksm page. So I'd rather keep it different even now, given I doubt it's moving the needle anywhere in ksm code. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/