Date: Tue, 21 Jul 2009 12:20:58 -0700 (PDT)
Message-Id: <20090721.122058.23378599.davem@davemloft.net>
To: fthain@telegraphics.com.au
Cc: u.kleine-koenig@pengutronix.de, gregkh@suse.de,
       linux-kernel@vger.kernel.org, jgarzik@redhat.com, geert@linux-m68k.org,
       akpm@linux-foundation.org
Subject: Re: [PATCH] move macsonic's probe function to .devinit.text
From: David Miller <davem@davemloft.net>
In-Reply-To: <alpine.OSX.2.00.0907220032230.796@silk.local>
References: <1247345591-22643-19-git-send-email-u.kleine-koenig@pengutronix.de>
	<1247345591-22643-20-git-send-email-u.kleine-koenig@pengutronix.de>
	<alpine.OSX.2.00.0907220032230.796@silk.local>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1053
Lines: 28

From: Finn Thain <fthain@telegraphics.com.au>
Date: Wed, 22 Jul 2009 01:14:36 +1000 (EST)

> 
> 
> On Sat, 11 Jul 2009, Uwe Kleine-K?nig wrote:
> 
>> A pointer to mac_sonic_probe is passed to the core via
>> platform_driver_register and so the function must not disappear when
>> the .init sections are discarded.  Otherwise (if also having
>> HOTPLUG=y) unbinding and binding a device to the driver via sysfs will
>> result in an oops as does a device being registered late.
> 
> This patch works for me (tested on a Quadra 630). I still get an oops
> on rmmod, but that's a separate issue. I'll send a patch for that.

Applied, but Uwe _please_ post networking patches to
netdev@vger.kernel.org so that they get properly logged
and tracked at:

http://patchwork.ozlabs.org/project/netdev/list/

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/