Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755902AbZGVCUH (ORCPT ); Tue, 21 Jul 2009 22:20:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755660AbZGVCUH (ORCPT ); Tue, 21 Jul 2009 22:20:07 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:56137 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1755566AbZGVCUG (ORCPT ); Tue, 21 Jul 2009 22:20:06 -0400 Message-ID: <4A6676F4.7070201@cn.fujitsu.com> Date: Wed, 22 Jul 2009 10:18:28 +0800 From: Li Zefan User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 MIME-Version: 1.0 To: Danny Feng CC: Paul Menage , containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cgroup: fix reverse unlock sequence in cgroup_get_sb References: <1248171926-20232-1-git-send-email-dfeng@redhat.com> <6599ad830907210903q7206cac2l83a9139d19c5e1a@mail.gmail.com> <4A667218.7040105@redhat.com> In-Reply-To: <4A667218.7040105@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1473 Lines: 47 Danny Feng wrote: > On 07/22/2009 12:03 AM, Paul Menage wrote: >> On Tue, Jul 21, 2009 at 3:25 AM, Xiaotian Feng wrote: >>> In cgroup_get_sb, the lock sequence is: >>> mutex_lock(&inode->i_mutex); >>> mutex_lock(&cgroup->mutex); >>> so the last unlock sequence should be: >> >> Make this "so for consistency the last ..." ? >> >> Maybe make the patch title "Make unlock sequence in cgroup_get_sb >> consistent" so someone looking through the change logs for fixes to >> backport doesn't wrongly thing that this fixes any bug"? >> > > Yep, this is a trivial patch. Modified following your suggestion, thank > you. > As far as it's not declared as a fix, I has no objection to this patch. Please always inline the patch in the mail body. And when resending the patch, add the acked-by you collected in it: Acked-by: Balbir ... Acked-by: Paul ... Signed-off-by: Xiaotian ... You may resend the patch to Andrew Morton, who picks up cgroup patches, otherwise the patch may be overlooked. >>> mutex_unlock(&cgroup->mutex); >>> mutex_unlock(&inode->i_mutex); >>> >>> Signed-off-by: Xiaotian Feng >> >> Acked-by: Paul Menage >> >> Paul > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/