Date: Tue, 21 Jul 2009 20:47:04 -0700 (PDT)
Message-Id: <20090721.204704.123531717.davem@davemloft.net>
To: petkovbb@googlemail.com
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ide-tape: fix handling of postponed rqs
From: David Miller <davem@davemloft.net>
In-Reply-To: <1247910917-5237-4-git-send-email-petkovbb@gmail.com>
References: <1247910917-5237-1-git-send-email-petkovbb@gmail.com>
	<1247910917-5237-4-git-send-email-petkovbb@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=utf-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 829
Lines: 21

From: Borislav Petkov <petkovbb@googlemail.com>
Date: Sat, 18 Jul 2009 11:55:17 +0200

> ide-tape used to hit
> 
> [   58.614854] ide-tape: ht0: BUG: Two DSC requests queued!
> 
> due to the fact that another rq was being issued while the driver was
> waiting for DSC to get set for the device executing ATAPI commands which
> set the DSC to 1 to indicate completion.
> 
> Here's a sample output of that case:

Do you even compile the code you send me and look to see if there are
any new warnings generated or anything like that?

drivers/ide/ide-tape.c: In function ‘ide_tape_stall_queue’:
drivers/ide/ide-tape.c:379: warning: unused variable ‘rq’

Fix this.
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?