Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752755AbZGVFRo (ORCPT ); Wed, 22 Jul 2009 01:17:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752219AbZGVFRn (ORCPT ); Wed, 22 Jul 2009 01:17:43 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:41277 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751986AbZGVFRn (ORCPT ); Wed, 22 Jul 2009 01:17:43 -0400 Date: Wed, 22 Jul 2009 07:17:39 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Nicolas Pitre Cc: "linux-kernel@vger.kernel.org" , Lennert Buijtenhek , Saeed Bishara , =?iso-8859-1?Q?J=F6rn?= Engel , Andrew Morton , Greg Kroah-Hartman , David Woodhouse , "linux-mtd@lists.infradead.org" Subject: Re: [PATCH] register orion_nand using platform_driver_probe Message-ID: <20090722051739.GA614@pengutronix.de> References: <1248209196-15705-1-git-send-email-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1760 Lines: 43 Hi Nicolas, On Tue, Jul 21, 2009 at 06:26:50PM -0400, Nicolas Pitre wrote: > On Tue, 21 Jul 2009, Uwe Kleine-K?nig wrote: > > > orion_nand_probe lives in .init.text, so using platform_driver_register > > to register it is wrong because binding a device after the init memory > > is discarded (e.g. via sysfs) results in an oops. > > > > As requested by Nicolas Pitre platform_driver_probe is used instead of > > moving the probe function to .devinit.text as proposed initially. > > This saves some memory, but devices registered after the driver is > > probed are not bound (probably there are none) and binding via sysfs > > isn't possible. > > > > Signed-off-by: Uwe Kleine-K?nig > > Cc: Lennert Buytenhek > > Cc: Saeed Bishara > > Cc: J?rn Engel > > Cc: Nicolas Pitre > > Cc: Tzachi Perelstein > > Cc: Andrew Morton > > Cc: Greg Kroah-Hartman > > Cc: David Woodhouse > > Cc: linux-mtd@lists.infradead.org > > Acked-by: Nicolas Pitre Did you test if all devices bind as expected? > Thanks. BTW Tzachi's email address is no longer valid. Yes, I got a mail from Marvell's mailer daemon stating the same. :-) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/