Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753048AbZGVKlF (ORCPT ); Wed, 22 Jul 2009 06:41:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751845AbZGVKlE (ORCPT ); Wed, 22 Jul 2009 06:41:04 -0400 Received: from ns2.tasking.nl ([195.193.207.10]:35713 "EHLO ns2.tasking.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751493AbZGVKlC (ORCPT ); Wed, 22 Jul 2009 06:41:02 -0400 X-Greylist: delayed 478 seconds by postgrey-1.27 at vger.kernel.org; Wed, 22 Jul 2009 06:41:01 EDT To: linux-kernel@vger.kernel.org Mime-Version: 1.0 X-Newsreader: knews 1.0b.1 Reply-To: dick.streefland@altium.nl (Dick Streefland) Organization: Altium BV X-Face: "`*@3nW;mP[=Z(!`?W;}cn~3M5O_/vMjX&Pe!o7y?xi@;wnA&Tvx&kjv'N\P&&5Xqf{2CaT 9HXfUFg}Y/TT^?G1j26Qr[TZY%v-1A<3?zpTYD5E759Q?lEoR*U1oj[.9\yg_o.~O.$wj:t(B+Q_?D XX57?U,#b,iM$[zX'I(!'VCQM)N)x~knSj>M*@l}y9(tK\rYwdv%~+&*jV"epphm>|q~?ys:g:K#R" 2PuAzy-N9cKM From: dick.streefland@altium.nl (Dick Streefland) Subject: Re: Linux 2.6.27.27 Content-Type: text/plain; charset=us-ascii NNTP-Posting-Host: 172.17.1.66 Message-ID: <2419.4a66eadd.ced9e@altium.nl> Date: Wed, 22 Jul 2009 10:33:01 -0000 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1234 Lines: 30 Krzysztof Oledzki wrote: | Here is a diff between a good and a bad kernel: | | -edid_checksum debug: csum=0, all_null=255, err=1 | -edid_checksum debug: csum=0, all_null=255, err=1 | -Console: switching to colour frame buffer device 128x48 | +edid_checksum debug: csum=6400, all_null=255, err=0 | +Console: switching to colour frame buffer device 80x30 | | In the good one the function is called twice and it returns err=1 (==OK). | In the bad kernel it returns 0 because csum!=0x00 (==6400). Linus accidentally dropped the "char" from the declaration of "csum" and "all_null": > - unsigned char i, csum = 0, all_null = 0; > - int err = 0, fix = check_edid(edid); > + unsigned csum = 0, all_null = 0; > + int i, err = 0, fix = check_edid(edid); -- Dick Streefland //// Altium BV dick.streefland@altium.nl (@ @) http://www.altium.com --------------------------------oOO--(_)--OOo--------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/