Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753694AbZGVLj0 (ORCPT ); Wed, 22 Jul 2009 07:39:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752885AbZGVLjZ (ORCPT ); Wed, 22 Jul 2009 07:39:25 -0400 Received: from cantor2.suse.de ([195.135.220.15]:42358 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751816AbZGVLjY (ORCPT ); Wed, 22 Jul 2009 07:39:24 -0400 Date: Wed, 22 Jul 2009 13:39:22 +0200 Message-ID: From: Takashi Iwai To: Mark Brown Cc: Janusz Krzysztofik , alsa-devel@alsa-project.org, Jonathan McDowell , Tony Lindgren , Peter Ujfalusi , "linux-kernel@vger.kernel.org" , e3-hacking@earth.li, Arun KS , "linux-serial@vger.kernel.org" , "linux-omap@vger.kernel.org" , Alan Cox Subject: Re: [alsa-devel] [RFC] [PATCH 3/3] ASoC: add support for Amstrad E3 (Delta) machine In-Reply-To: <20090722110328.GB7622@sirena.org.uk> References: <200907220523.01107.jkrzyszt@tis.icnet.pl> <20090722110328.GB7622@sirena.org.uk> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 629 Lines: 20 At Wed, 22 Jul 2009 12:03:28 +0100, Mark Brown wrote: > > > + /* Setup pins after corresponding bits if changed */ > > + if ((bool)snd_soc_dapm_get_pin_status(codec, "Speaker") != > > + (bool)(function & (1 << AMS_DELTA_SPEAKER))) { > > Don't like these casts... why are they needed? Because the right side is the bit operation? The cast doesn't look nice, though... Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/