Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755186AbZGVNGI (ORCPT ); Wed, 22 Jul 2009 09:06:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754892AbZGVNGH (ORCPT ); Wed, 22 Jul 2009 09:06:07 -0400 Received: from mk-filter-2-a-1.mail.uk.tiscali.com ([212.74.100.53]:37754 "EHLO mk-filter-2-a-1.mail.uk.tiscali.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754608AbZGVNGG (ORCPT ); Wed, 22 Jul 2009 09:06:06 -0400 X-Trace: 233670711/mk-filter-2.mail.uk.tiscali.com/B2C/$b2c-THROTTLED-DYNAMIC/b2c-CUSTOMER-DYNAMIC-IP/79.69.68.55/None/hugh.dickins@tiscali.co.uk X-SBRS: None X-RemoteIP: 79.69.68.55 X-IP-MAIL-FROM: hugh.dickins@tiscali.co.uk X-SMTP-AUTH: X-MUA: X-IP-BHB: Once X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AuAEACCrZkpPRUQ3/2dsb2JhbACBUc9WhA4F X-IronPort-AV: E=Sophos;i="4.43,247,1246834800"; d="scan'208";a="233670711" Date: Wed, 22 Jul 2009 14:05:55 +0100 (BST) From: Hugh Dickins X-X-Sender: hugh@sister.anvils To: Andrea Arcangeli cc: Izik Eidus , akpm@linux-foundation.org, chrisw@redhat.com, avi@redhat.com, riel@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nickpiggin@yahoo.com.au Subject: Re: [PATCH 00/10] ksm resend In-Reply-To: <20090721175909.GF2239@random.random> Message-ID: References: <1247851850-4298-1-git-send-email-ieidus@redhat.com> <20090721175909.GF2239@random.random> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1444 Lines: 38 On Tue, 21 Jul 2009, Andrea Arcangeli wrote: > On Fri, Jul 17, 2009 at 08:30:40PM +0300, Izik Eidus wrote: > > The code still need to get Andrea Arcangeli acks. > > (he was busy and will ack it later). > > Ack it all except that detail in 6/10 Thanks a lot, Andrea. > as I'm unconvinced about ksm > pages having to return 1 on PageAnon check. I believe they deserve a > different bitflag in the mapping pointer. The smallest possible > alignment for mapping pointer is 4 on 32bit archs so there is space > for it Yes, I believe they'll deserve that too, but set in addition to PAGE_MAPPING_ANON. And perhaps you or someone else will then have another use for the new bit when PAGE_MAPPING_ANON is not set. > and later it can be renamed EXTERNAL to generalize. We shall > make good use of that bitflag as it's quite precious to introduce > non-linearity in linear vmas, and not wire it to KSM only. You have something in mind here... > But in > meantime we'll get better testing coverage by not having that PageKsm > == PageAnon invariant I think that I doubt we're going to retain (at > least with this implementation of PageKsm). PageKsm subset of PageAnon: I expect to retain that. Hugh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/