Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752375AbZGVPif (ORCPT ); Wed, 22 Jul 2009 11:38:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751860AbZGVPie (ORCPT ); Wed, 22 Jul 2009 11:38:34 -0400 Received: from terminus.zytor.com ([198.137.202.10]:40474 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751854AbZGVPie (ORCPT ); Wed, 22 Jul 2009 11:38:34 -0400 Message-ID: <4A671F54.7050101@zytor.com> Date: Wed, 22 Jul 2009 07:16:52 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.1.1) Gecko/20090715 Thunderbird/3.0b3 MIME-Version: 1.0 To: Andi Kleen CC: Hidetoshi Seto , Hidehiro Kawai , mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org, Satoshi OSHIMA , Taketoshi Sakuraba Subject: Re: [PATCH] x86, mce: Rename incorrect macro name "CONFIG_X86_THRESHOLD" References: <4A667FD4.3010509@hitachi.com> <4A668964.5040800@jp.fujitsu.com> <4A671206.500@linux.intel.com> In-Reply-To: <4A671206.500@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 759 Lines: 21 On 07/22/2009 06:20 AM, Andi Kleen wrote: > >> It seems that this ifdef was introduced by the following merge commit: > > I also managed to introduce similar bugs during merges in the past. > It's very easy and hard to find. > > Perhaps it would be good if we had some automated tool that checks > all CONFIG_*s referenced exist in Kconfig and that is run regularly. There is checkkconfigsymbols.sh... -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/