Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753147AbZGVPu7 (ORCPT ); Wed, 22 Jul 2009 11:50:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752575AbZGVPu6 (ORCPT ); Wed, 22 Jul 2009 11:50:58 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:50894 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752523AbZGVPu6 (ORCPT ); Wed, 22 Jul 2009 11:50:58 -0400 Date: Wed, 22 Jul 2009 08:48:48 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Krzysztof Oledzki cc: Troy Moure , Greg KH , Linux Kernel Mailing List , Andrew Morton , stable@kernel.org, lwn@lwn.net, Ian Lance Taylor Subject: Re: Linux 2.6.27.27 In-Reply-To: Message-ID: References: <20090720040655.GA11940@kroah.com> <4A645A45.9060509@ans.pl> <20090720151008.GC10015@suse.de> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1379 Lines: 46 On Wed, 22 Jul 2009, Krzysztof Oledzki wrote: > > > On Tue, 21 Jul 2009, Linus Torvalds wrote: > > > > IOW, like this. Yeah, I'm a moron. Not at _all_ like that. I wish I hadn't sent out the patch, you'd have done it correctly by hand from my description. > > diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c > > index 5c1a2c0..af4a15c 100644 > > --- a/drivers/video/fbmon.c > > +++ b/drivers/video/fbmon.c > > @@ -256,8 +256,8 @@ static void fix_edid(unsigned char *edid, int fix) > > > > static int edid_checksum(unsigned char *edid) > > { > > - unsigned char i, csum = 0, all_null = 0; > > - int err = 0, fix = check_edid(edid); > > + unsigned csum = 0, all_null = 0; > > + int i, err = 0, fix = check_edid(edid); I don't know where the 'char' disappeared, but that was obviously not intended. I just meant to move the 'i' from one line to the other. > > > > if (fix) > > fix_edid(edid, fix); > > Tested-by: Krzysztof Piotr Oledzki > > On condition, that you keep "unsigned char" here. ;) Indeed. I'll commit the fixed version. Thanks for testing and sorry for the idiot patch. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/