Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753850AbZGVQuq (ORCPT ); Wed, 22 Jul 2009 12:50:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753734AbZGVQup (ORCPT ); Wed, 22 Jul 2009 12:50:45 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:49978 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753576AbZGVQuo (ORCPT ); Wed, 22 Jul 2009 12:50:44 -0400 Date: Wed, 22 Jul 2009 17:50:42 +0100 From: Mark Brown To: David Brownell Cc: Thomas Gleixner , Dmitry Torokhov , Trilok Soni , Pavel Machek , Arve Hj?nnev?g , kernel list , Brian Swetland , linux-input@vger.kernel.org, Andrew Morton , linux-i2c@vger.kernel.org, Joonyoung Shim , m.szyprowski@samsung.com, t.fujak@samsung.com, kyungmin.park@samsung.com, Peter Zijlstra Subject: Re: Threaded interrupts for synaptic touchscreen in HTC dream Message-ID: <20090722165042.GA21186@rakim.wolfsonmicro.main> References: <20090714100634.GA4054@elf.ucw.cz> <20090721160436.GD4352@dtor-d630.eng.vmware.com> <200907220939.33399.david-b@pacbell.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200907220939.33399.david-b@pacbell.net> X-Cookie: Sign here without admitting guilt. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1078 Lines: 21 On Wed, Jul 22, 2009 at 09:39:32AM -0700, David Brownell wrote: > The normal model is that boards don't get involved with that level of > logic ... all IRQs get set up once on generic code, and flow handlers > don't change. Or if they do change, it's done when changing the IRQ's > trigger mode from edge to level, or vice versa. > Can that be cleaned up a bit, so that the handle_level_oneshot_irq() > and unmask_oneshot_irq() stuff kicks in automatically when needed, > instead of requiring board-specific (or driver-specific) code to get > that stuff right? Thomas was reluctant to do that but up till now every single user has been asking for it. A flag in the driver requesting the behaviour sounds OK to me, there are devices that can use threaded IRQs while interacting with the device in the primary handler NAPI style. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/