Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754100AbZGVRq1 (ORCPT ); Wed, 22 Jul 2009 13:46:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752746AbZGVRq0 (ORCPT ); Wed, 22 Jul 2009 13:46:26 -0400 Received: from fg-out-1718.google.com ([72.14.220.152]:46106 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752745AbZGVRqZ (ORCPT ); Wed, 22 Jul 2009 13:46:25 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=s647REFf9lmZhxK0SBXk1Jeg/aYhf/M1eXQCgMdUXVR2qu9+Gm4+tuCDfflQCjN+No zh4/Q9eUSFZ76f5roTCUPWUefTuGxGBIf3alWI6XFbVihSCVYZa4Q2RHkChWpJReWmb1 jrXqy1bs6CftMisVEXPqf+gYoxBOV/HaAXc/Q= MIME-Version: 1.0 In-Reply-To: <1248207099-14583-1-git-send-email-u.kleine-koenig@pengutronix.de> References: <200907111527.46441.david-b@pacbell.net> <1248207099-14583-1-git-send-email-u.kleine-koenig@pengutronix.de> Date: Wed, 22 Jul 2009 19:46:24 +0200 Message-ID: Subject: Re: [PATCH] register at91_ether using platform_driver_probe From: Andrew Victor To: =?ISO-8859-1?Q?Uwe_Kleine=2DK=F6nig?= Cc: linux-kernel@vger.kernel.org, David Brownell , netdev@vger.kernel.org, Paulius Zaleckas , Marc Pignat , Andrew Victor , Roel Kluin <12o3l@tiscali.nl>, Andrew Morton , Greg Kroah-Hartman Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 797 Lines: 19 hi, > at91ether_probe lives in .init.text, so using platform_driver_register > to register it is wrong because binding a device after the init memory > is discarded (e.g. via sysfs) results in an oops. > > As requested by David Brownell platform_driver_probe is used instead of > moving the probe function to .devinit.text as proposed initially. > This saves some memory, but devices registered after the driver is > probed are not bound (probably there are none) and binding via sysfs > isn't possible. Acked-by: Andrew Victor -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/