From: Ferenc Wagner <wferi@niif.hu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Ray Lee <ray-lk@madrabbit.org>, Andrew Morton <akpm@linux-foundation.org>,
       Peter Staubach <staubach@redhat.com>, Miklos Szeredi <mszeredi@suse.cz>,
       xfs@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: mmap vs mtime in 2.6.26 and up
References: <20090518114305.GA6303@infradead.org>
Date: Wed, 22 Jul 2009 19:52:09 +0200
In-Reply-To: <20090518114305.GA6303@infradead.org> (Christoph Hellwig's
	message of "Mon, 18 May 2009 07:43:05 -0400")
Message-ID: <87ab2w8v1y.fsf@tac.ki.iif.hu>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1490
Lines: 36

Christoph Hellwig <hch@infradead.org> writes:

> On Fri, May 15, 2009 at 12:50:54PM -0400, Christoph Hellwig wrote:
>> On Fri, May 15, 2009 at 06:40:29PM +0200, Ferenc Wagner wrote:
>>> Thanks for the analysis.  Unfortunately I don't nearly know enough to
>>> work on this issue, but would like to track it as it affects our
>>> backup system.  So, shouldn't #2645 be reopened again?
>> 
>> Yes, definitively as the current "fix" is incorrected.  I'll try to cook
>> up a correct version once I get some time.
>
> Doing this correctly in the framework of the current codee is
> unfortunately not so easy, as calling ->setattr requires taking i_mutex
> which we can't in the pagefaul path.
>
> To fix this properly we need to actually update the timestamps during
> msync and co as done by the patches from Miklos:
> 	http://lkml.org/lkml/2007/2/28/166
> and Peter:
> 	http://lkml.org/lkml/2006/5/31/176

Hi Christoph,

http://bugzilla.kernel.org/show_bug.cgi?id=2645#c53 shows that Anton
doesn't quite agree with you on this.  I really can't tell, would you
(or anybody from the accused XFS community) please comment?  Or did
you perhaps fix it meanwhile?  I can't easily test never kernels, but
I will if there's some chance.
-- 
Thanks,
Feri.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/