Date: Wed, 22 Jul 2009 11:24:56 -0700 (PDT)
Message-Id: <20090722.112456.150910386.davem@davemloft.net>
To: avictor.za@gmail.com
Cc: u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org,
       dbrownell@users.sourceforge.net, netdev@vger.kernel.org,
       paulius.zaleckas@teltonika.lt, marc.pignat@hevs.ch, linux@maxim.org.za,
       12o3l@tiscali.nl, akpm@linux-foundation.org, gregkh@suse.de
Subject: Re: [PATCH] register at91_ether using platform_driver_probe
From: David Miller <davem@davemloft.net>
In-Reply-To: <cd73a99e0907221046k5e435fd3m3cb1fd006c0385a7@mail.gmail.com>
References: <200907111527.46441.david-b@pacbell.net>
	<1248207099-14583-1-git-send-email-u.kleine-koenig@pengutronix.de>
	<cd73a99e0907221046k5e435fd3m3cb1fd006c0385a7@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 925
Lines: 24

From: Andrew Victor <avictor.za@gmail.com>
Date: Wed, 22 Jul 2009 19:46:24 +0200

> hi,
> 
>> at91ether_probe lives in .init.text, so using platform_driver_register
>> to register it is wrong because binding a device after the init memory
>> is discarded (e.g. via sysfs) results in an oops.
>>
>> As requested by David Brownell platform_driver_probe is used instead of
>> moving the probe function to .devinit.text as proposed initially.
>> This saves some memory, but devices registered after the driver is
>> probed are not bound (probably there are none) and binding via sysfs
>> isn't possible.
> 
> 
> Acked-by: Andrew Victor <linux@maxim.org.za>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/