Message-ID: <4A67BBDC.7040207@zytor.com>
Date: Wed, 22 Jul 2009 18:24:44 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.1.1) Gecko/20090715 Thunderbird/3.0b3
MIME-Version: 1.0
To: Andrew Morton <akpm@linux-foundation.org>
CC: Mike Rapoport <mike@compulab.co.il>, linux-kernel@vger.kernel.org,
       denis@compulab.co.il
Subject: Re: [PATCH] Add reboot fixup for SBC-fitPC2
References: <4A6491C1.5060909@compulab.co.il> <20090722173854.fdbcee7f.akpm@linux-foundation.org>
In-Reply-To: <20090722173854.fdbcee7f.akpm@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1201
Lines: 33

On 07/22/2009 05:38 PM, Andrew Morton wrote:
> 
> Neither this patch nor Denis's earlier version contained an adequate
> decription.  We aren't told what these "problems" are, so we're unable
> to judge the appropriateness of patch.
> 
> Both patches were wordwrapped.
> 
> Both patches use an atypical layout style for the comments.
> 
> I fixed up some of these things and merged the patch into my tree, for
> sending to Ingo for 2.6.32.
> 
> Please send a description of the problem which the patch fixes and I
> shall add that to my copy of the changelog.
> 

I queued up an equivalent cleaned up version for tip:x86/urgent that I
was planning to push to Linus.  However, as you quite correctly point
out the comments in this file are pretty darn pointless; they add
absolutely no information over what is already in the data structure.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/