Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752490AbZGWKQZ (ORCPT ); Thu, 23 Jul 2009 06:16:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752062AbZGWKQZ (ORCPT ); Thu, 23 Jul 2009 06:16:25 -0400 Received: from mga09.intel.com ([134.134.136.24]:23796 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751141AbZGWKQY (ORCPT ); Thu, 23 Jul 2009 06:16:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.43,253,1246863600"; d="scan'208";a="432661254" Date: Thu, 23 Jul 2009 18:15:25 +0800 From: Feng Tang To: Alexander Beregalov CC: Len Brown , linux-next , Linux Kernel Mailing List , "linux-acpi@vger.kernel.org" Subject: Re: next: sfi build fails when !CONFIG_ACPI Message-ID: <20090723181525.475692d3@feng-desktop> In-Reply-To: References: Organization: intel X-Mailer: Claws Mail 3.5.0 (GTK+ 2.14.4; i486-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1407 Lines: 49 On Thu, 23 Jul 2009 16:43:30 +0800 Alexander Beregalov wrote: > 2009/7/17 Alexander Beregalov : > > 2009/7/17 Len Brown : > >>> drivers/sfi/sfi_core.c: In function 'sfi_init': > >>> drivers/sfi/sfi_core.c:346: error: 'acpi_disabled' undeclared > >>> (first use in this function) > >>> drivers/sfi/sfi_core.c:346: error: (Each undeclared identifier is > >>> reported only once > >>> drivers/sfi/sfi_core.c:346: error: for each function it appears > >>> in.) > >>> > >>> > >>> $ grep ACPI .config > >>> # Power management and ACPI options > >> > >> It builds for me. > >> Please send me the complete failing .config > > > > Attached (x86_64) > > Still fails for me in the same way, > X86_64 > next-20090723 sorry for the late response, please try the following patch: diff --git a/drivers/sfi/sfi_core.c b/drivers/sfi/sfi_core.c index 62e2f98..fa66824 100644 --- a/drivers/sfi/sfi_core.c +++ b/drivers/sfi/sfi_core.c @@ -361,9 +361,6 @@ static __init int sfi_find_syst(void) void __init sfi_init(void) { - if (!acpi_disabled) - disable_sfi(); - if (sfi_disabled) return; Thanks, Feng -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/