Subject: Re: [PATCH] jfs: Fix early release of acl in jfs_get_acl
From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
To: Stefan Bader <stefan.bader@canonical.com>
Cc: jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org,
       Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
       Andy Whitcroft <apw@canonical.com>, Christophe Dumez <dchris@gmail.com>
In-Reply-To: <4A687796.80200@canonical.com>
References: <4A687796.80200@canonical.com>
Content-Type: text/plain
Date: Thu, 23 Jul 2009 11:16:32 -0500
Message-Id: <1248365792.29722.3.camel@norville.austin.ibm.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1227
Lines: 33

On Thu, 2009-07-23 at 16:45 +0200, Stefan Bader wrote:
> Commit 073aaa1b142461d91f83da66db1184d7c1b1edea "helpers for acl
> caching + switch to those" introduced new helper functions for
> acl handling but seems to have introduced a regression for jfs as the
> acl is released before returning it to the caller, instead of
> leaving this for the caller to do.
> This causes the acl object to be used after freeing it, leading
> to kernel panics in completely different places.

This looks good.  Thanks much!  I'll get it upstream as soon as
possible.

> Thanks to Christophe Dumez for reporting and bisecting into this.
> 
> Reported-by: Christophe Dumez <dchris@gmail.com>
> Tested-by: Christophe Dumez <dchris@gmail.com>
> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
> Acked-by: Andy Whitcroft <apw@canonical.com>
> ---
>   fs/jfs/acl.c |    4 +---
>   1 files changed, 1 insertions(+), 3 deletions(-)

Thanks,
Shaggy
-- 
David Kleikamp
IBM Linux Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/