Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754731AbZGXX6t (ORCPT ); Fri, 24 Jul 2009 19:58:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754424AbZGXX6s (ORCPT ); Fri, 24 Jul 2009 19:58:48 -0400 Received: from g5t0008.atlanta.hp.com ([15.192.0.45]:7789 "EHLO g5t0008.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754395AbZGXX6r (ORCPT ); Fri, 24 Jul 2009 19:58:47 -0400 Date: Fri, 24 Jul 2009 17:58:47 -0600 From: Alex Chiang To: Jesse Barnes Cc: lenb@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v3 2/2] PCI Hotplug: acpiphp: get pci_bus from acpi handle correctly Message-ID: <20090724235847.GD21376@ldl.fc.hp.com> References: <20090723230026.4247.12759.stgit@bob.kio> <20090723230305.4247.81288.stgit@bob.kio> <20090724143827.31b4c37d@jbarnes-g45> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090724143827.31b4c37d@jbarnes-g45> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1114 Lines: 32 * Jesse Barnes : > On Thu, 23 Jul 2009 17:03:05 -0600 > Alex Chiang wrote: > > > We cannot simply call acpi_get_pci_dev() on any random ACPI handle > > and hope that it works, because a PCI root bridge may not have > > an associated struct pci_dev. > > > > This is allowed per the PCI specification, and is referred to as a > > non-materialized bridge. > > > > So, depending on the type of PCI bridge that the handle points to, > > use the appropriate interface to return the struct pci_bus correctly. > > > > Signed-off-by: Alex Chiang > > --- > > I put these in my linux-next branch, just because I'm really > conservative about the current release. > > If we hear of boxes in the wild getting bitten by the non-materialized > bit, we can push this set back to stable. Sounds good, thanks Jesse. /ac -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/