Date: Sat, 25 Jul 2009 12:23:59 +0100
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: linux-kernel@vger.kernel.org
Message-ID: <20090725112359.GB4600@sirena.org.uk>
References: <1246550798-9936-1-git-send-email-broonie@opensource.wolfsonmicro.com>
 <20090713113017.GB24783@sirena.org.uk>
 <20090724223554.GA10055@sortiz.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090724223554.GA10055@sortiz.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Subject: Re: [PATCH/RFC] mfd: Allow multiple MFD cells with the same name
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1332
Lines: 28

On Sat, Jul 25, 2009 at 12:35:55AM +0200, Samuel Ortiz wrote:
> On Mon, Jul 13, 2009 at 12:30:18PM +0100, Mark Brown wrote:

> > Samuel, do you have any thoughts on this patch?  As I said...

> I think it's safe to expect people that decide they need this feature will be
> careful enough to make sure they dont get ID collisions.

Yes, and it should be fairly easy to work out what's gone wrong if there
are any problems.

> > ...but it'd be really helpful to get some idea if this approach is going
> > to be viable for some code I'm currently working on.

> I'm ok with this patch, but I'd like the new cell->id field to be more
> documented. In particular we should mention that one should leave it to 0
> unless trying to add several cells of the same type.
> I'll push this patch once I'll be back from vacation, thanks.

OK, thanks.  I'm not sure when you're back from your vacation but early
next week I should be releasing the code which I was mentioning above -
if you've not applied it before then I'll try to include a revised
version with more documentation in that series.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/