Subject: Re: linux-2.5.6 scsi DMA mapping and compilation fixes (not yet working)
To: rmk@arm.linux.org.uk (Russell King)
Date: Wed, 13 Mar 2002 16:51:49 +0000 (GMT)
Cc: adam@yggdrasil.com (Adam J. Richter), linux-kernel@vger.kernel.org
In-Reply-To: <20020312234256.B13558@flint.arm.linux.org.uk> from "Russell King" at Mar 12, 2002 11:42:56 PM
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <E16lByf-0006ph-00@the-village.bc.nu>
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Sender: linux-kernel-owner@vger.kernel.org

> I believe changes to NCR53c80 were recently reverted back because
> these "fixes" lead to massive data corruption.  It is preferable
> that the driver remains unbuildable, and therefore doesn't cause
> data corruption than to be buildable and case data corruption.

Someone "fixed" the 2.5 one by just frobbing randomly with the
io_request_lock without noticing its not always used per queue in the driver
(study the host list code - and dont think you can just clean that up by
 using SHIRQ - that wont help on some non x86 stuff). I fed Dave Jones
the 2.4 stuff where the locking is fixed (tho using io_request_lock) and
actually works SMP.

Dave then I suspect fed it to Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/