Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753640AbZGZPIo (ORCPT ); Sun, 26 Jul 2009 11:08:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753598AbZGZPIn (ORCPT ); Sun, 26 Jul 2009 11:08:43 -0400 Received: from cassiel.sirena.org.uk ([80.68.93.111]:58837 "EHLO cassiel.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753581AbZGZPIm (ORCPT ); Sun, 26 Jul 2009 11:08:42 -0400 Date: Sun, 26 Jul 2009 16:08:34 +0100 From: Mark Brown To: "Rafael J. Wysocki" Cc: Dmitry Torokhov , Frans Pop , Manuel Lauss , linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Manuel Lauss Message-ID: <20090726150834.GB27022@sirena.org.uk> References: <1248275919-3296-1-git-send-email-manuel.lauss@gmail.com> <200907252019.01266.elendil@planet.nl> <20090725191037.GE14062@dtor-d630.eng.vmware.com> <200907252139.30674.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200907252139.30674.rjw@sisk.pl> X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: 82.41.28.43 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH V2] au1xmmc: dev_pm_ops conversion X-SA-Exim-Version: 4.2.1 (built Wed, 25 Jun 2008 17:14:11 +0000) X-SA-Exim-Scanned: Yes (on cassiel.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 627 Lines: 16 On Sat, Jul 25, 2009 at 09:39:30PM +0200, Rafael J. Wysocki wrote: > Yes, they would. In general, you'd probably want to do something like this: > static struct dev_pm_ops au1xmmc_pmops = { > .resume = au1xmmc_resume, > .suspend = au1xmmc_suspend, > .freeze = au1xmmc_resume, > .thaw = au1xmmc_suspend, I'd have expected freeze and thaw to be the other way around here? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/