From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Frans Pop <elendil@planet.nl>
Subject: Re: [PATCH v2 -tip][RFC] serial8250: update to dev_pm_ops
Date: Mon, 27 Jul 2009 00:38:25 +0200
User-Agent: KMail/1.11.2 (Linux/2.6.31-rc4-rjw; KDE/4.2.4; x86_64; ; )
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, Erik Ekman <erik@kryo.se>,
       Alan Cox <alan@linux.intel.com>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
       Magnus Damm <magnus.damm@gmail.com>
References: <20090701083737.41f28c7d.erik@kryo.se> <200907262145.46363.rjw@sisk.pl> <200907262252.41429.elendil@planet.nl>
In-Reply-To: <200907262252.41429.elendil@planet.nl>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200907270038.26549.rjw@sisk.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1040
Lines: 26

On Sunday 26 July 2009, Frans Pop wrote:
> On Sunday 26 July 2009, Rafael J. Wysocki wrote:
> > In fact, I wouldn't advise anyone to do these conversions mechanically.
> 
> With hindsight I'd say you are correct.
> 
> In that case would it maybe have been better to have a build time warning 
> about the need to convert drivers rather than a run time one? Run time 
> warnings have a much higher annoyance factor and will thus "invite" more 
> people into having a shot at getting rid of them.
> 
> But I guess partly it's also just the nature of this change: it looks 
> trivial due to the corresponding terms.

Well, in fact the patch that added the warning wasn't mine. :-)

Anyway, the purpose was to get the attention of the people who maintain
those drivers mostly, AFAICS.

Best,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/