DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:from:date:message-id:subject:to:cc:content-type
         :content-transfer-encoding;
        b=uqjp76l7aJOhGcpmG36JGuY9lQ/m4wJvXmt0E6+/nQDG6zDFRwEAjmpzdzi2GXWA3o
         vUQUlA7qx7ABgpXaejAP/BZGJFGba9byQQtau57VfzhymGo92sGh6fRJodLmMJcXwmaj
         +S1ZoeFu7BCCrd5JiVFSwzR77ktSLSCsZz7Ss=
MIME-Version: 1.0
From: Mike Frysinger <vapier.adi@gmail.com>
Date: Mon, 27 Jul 2009 02:20:06 -0400
Message-ID: <8bd0f97a0907262320y3c5c3505h5d47d5c51025a536@mail.gmail.com>
Subject: early platform drivers vs resource lookup by name
To: Greg KH <gregkh@suse.de>, damm@igel.co.jp
Cc: linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1020
Lines: 26

ive been toying with the new early platform driver framework and
noticed a not-so-friendly feature wrt resource handling.  the
platform_device_add() function will take care of making sure that
every resource's name field is not NULL:
int platform_device_add(struct platform_device *pdev)
{
...
        if (r->name == NULL)
            r->name = dev_name(&pdev->dev);
...

unfortunately, the early_platform_add_devices() function does not have
similar code.  this leads to NULL pointer crashes if you attempt to
use any of the "byname" resource functions (e.g.
platform_get_resource_byname) and the resources in question arent
fully named.

is the simple fix here to add a resource loop to
early_platform_add_devices() that makes sure all the name fields are
non-NULL ?
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/