Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754281AbZG0H6m (ORCPT ); Mon, 27 Jul 2009 03:58:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754181AbZG0H6l (ORCPT ); Mon, 27 Jul 2009 03:58:41 -0400 Received: from smtp.nokia.com ([192.100.122.230]:34991 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751061AbZG0H6k (ORCPT ); Mon, 27 Jul 2009 03:58:40 -0400 Message-ID: <4A6D5E40.7030608@nokia.com> Date: Mon, 27 Jul 2009 10:58:56 +0300 From: Adrian Hunter User-Agent: Thunderbird 2.0.0.21 (X11/20090318) MIME-Version: 1.0 To: Matt Fleming CC: Pierre Ossman , "Lavinen Jarkko (Nokia-D/Helsinki)" , "Karpov Denis.2 (EXT-Teleca/Helsinki)" , lkml , linux-omap Mailing List Subject: Re: [PATCH 32/32] ARM: OMAP: RX51: set MMC capabilities and power-saving flag References: <20090710124004.1262.10422.sendpatchset@ahunter-tower> <20090710124353.1262.22788.sendpatchset@ahunter-tower> <20090725235329.GE12665@console-pimps.org> In-Reply-To: <20090725235329.GE12665@console-pimps.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 27 Jul 2009 07:58:23.0007 (UTC) FILETIME=[037CCAF0:01CA0E90] X-Nokia-AV: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3013 Lines: 95 Matt Fleming wrote: > On Fri, Jul 10, 2009 at 03:43:53PM +0300, Adrian Hunter wrote: >> >From 3865867159f25cf706480236f6d4f0e4adde5dac Mon Sep 17 00:00:00 2001 >> From: Adrian Hunter >> Date: Fri, 10 Jul 2009 10:32:44 +0300 >> Subject: [PATCH] ARM: OMAP: RX51: set MMC capabilities and power-saving flag >> >> Specify MMC capabilities and set the power-saving flag >> for RX51. >> > > After the changes to [PATCH 7/32], this becomes, I think this will leave every other board that uses omap_hsmmc without any card caps. What about adding something like this: diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 8900bae..f2548f1 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -1720,6 +1720,11 @@ static int __init omap_hsmmc_probe(struct platform_device *pdev) mmc->caps |= MMC_CAP_4_BIT_DATA; mmc->caps |= mmc_slot(host).caps; + /* If no card caps specified then assume them all */ + if (!((mmc->caps & MMC_CAP_SD) || + (mmc->caps & MMC_CAP_MMC) || + (mmc->caps & MMC_CAP_SDIO))) + mmc->caps |= MMC_CAP_SD & MMC_CAP_MMC & MMC_CAP_SDIO; omap_hsmmc_conf_bus_power(host); > --- > > ARM: OMAP: RX51: set MMC capabilities and power-saving flag > > Specify MMC capabilities and set the power-saving flag for RX51. > > Signed-off-by: Matt Fleming > Cc: Adrian Hunter > Cc: Ian Molton > Cc: "Roberto A. Foglietta" > Cc: Jarkko Lavinen > Cc: Denis Karpov > Cc: Pierre Ossman > Cc: Andrew Morton > --- > arch/arm/mach-omap2/board-rx51-peripherals.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c > index 9a0bf67..d2ce938 100644 > --- a/arch/arm/mach-omap2/board-rx51-peripherals.c > +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -102,6 +103,8 @@ static struct twl4030_hsmmc_info mmc[] = { > .cover_only = true, > .gpio_cd = 160, > .gpio_wp = -EINVAL, > + .power_saving = true, > + .caps = MMC_CAP_SD, > }, > { > .name = "internal", > @@ -109,6 +112,8 @@ static struct twl4030_hsmmc_info mmc[] = { > .wires = 8, > .gpio_cd = -EINVAL, > .gpio_wp = -EINVAL, > + .power_saving = true, > + .caps = MMC_CAP_MMC | MMC_CAP_NONREMOVABLE, > }, > {} /* Terminator */ > }; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/