Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755112AbZG0I1T (ORCPT ); Mon, 27 Jul 2009 04:27:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755059AbZG0I1T (ORCPT ); Mon, 27 Jul 2009 04:27:19 -0400 Received: from ip67-152-220-66.z220-152-67.customer.algx.net ([67.152.220.66]:17583 "EHLO daytona.int.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754980AbZG0I1S (ORCPT ); Mon, 27 Jul 2009 04:27:18 -0400 Message-ID: <4A6D64DC.3020001@panasas.com> Date: Mon, 27 Jul 2009 11:27:08 +0300 From: Boaz Harrosh User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090315 Remi/3.0-0.b2.fc10.remi Thunderbird/3.0b2 MIME-Version: 1.0 To: "Martin K. Petersen" CC: Matthew Wilcox , Tarkan Erimer , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [BISECTED] Re: [BUG] Linux-2.6.31-rc1 Fails To Recognize Some USB Disks References: <4A4472DF.1050900@turknet.net.tr> <4A4878AC.3050208@turknet.net.tr> <4A69932E.90906@turknet.net.tr> <4A69D093.8020108@turknet.net.tr> <20090727020611.GC3711@parisc-linux.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 27 Jul 2009 08:27:12.0490 (UTC) FILETIME=[0A56F4A0:01CA0E94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1247 Lines: 33 On 07/27/2009 05:43 AM, Martin K. Petersen wrote: >>>>>> "Matthew" == Matthew Wilcox writes: > > First let's see if I actually interpreted the responses correctly and > that this fixes the issue. > > Matthew> and the sd code seems to check for that. So what bug are you > Matthew> papering over here? > > The USB drive in question appears to go tits up when we send it an > extended inquiry. I contemplated adding a BLIST option but we really > only need EVPD to access pages 0xB0 and 0xB1. I don't understand. The device in question breaks when we try to read a page that it reported it supports? we did do /* Ask for all the pages supported by this device */ result = scsi_vpd_inquiry(sdev, buf, 0, 255); if (result) goto fail; Didn't we? Are we checking that 0xB0 or 0xB1 are returned? The Block Limits page > appeared in SBC2 so I'm just trying to play it safe. And hopefully fix > Tarkan's problem in the process. > Thanks Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/