Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754160AbZG0SgR (ORCPT ); Mon, 27 Jul 2009 14:36:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750695AbZG0SgQ (ORCPT ); Mon, 27 Jul 2009 14:36:16 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:44730 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752668AbZG0SgO (ORCPT ); Mon, 27 Jul 2009 14:36:14 -0400 Date: Mon, 27 Jul 2009 11:36:21 -0700 (PDT) Message-Id: <20090727.113621.207329776.davem@davemloft.net> To: paul.moore@hp.com Cc: julia@diku.dk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 11/12] net/netlabel: Correct redundant test From: David Miller In-Reply-To: <200907271337.30401.paul.moore@hp.com> References: <200907271337.30401.paul.moore@hp.com> X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 842 Lines: 24 From: Paul Moore Date: Mon, 27 Jul 2009 13:37:29 -0400 > On Monday 27 July 2009 12:15:43 pm Julia Lawall wrote: >> From: Julia Lawall >> >> entry was tested for NULL near the beginning of the function, followed by a >> return, and there is no intervening modification of its value. >> >> A simplified version of the semantic match that finds this problem is as >> follows: (http://www.emn.fr/x-info/coccinelle/) ... >> Signed-off-by: Julia Lawall > > Good catch, thanks. > > Acked-by: Paul Moore Applied to net-next-2.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/