Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754707AbZG0Up4 (ORCPT ); Mon, 27 Jul 2009 16:45:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754630AbZG0Upz (ORCPT ); Mon, 27 Jul 2009 16:45:55 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:53304 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754595AbZG0Upz (ORCPT ); Mon, 27 Jul 2009 16:45:55 -0400 Date: Mon, 27 Jul 2009 13:45:22 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: OGAWA Hirofumi cc: "Aneesh Kumar K.V" , Alan Cox , "Rafael J. Wysocki" , Ray Lee , LKML , Andrew Morton Subject: Re: [PATCH] kdesu broken In-Reply-To: <87ocr5dfpb.fsf@devron.myhome.or.jp> Message-ID: References: <20090725163251.50e6f546@lxorguk.ukuu.org.uk> <87bpn7mzli.fsf@devron.myhome.or.jp> <20090727115723.1e8de60e@lxorguk.ukuu.org.uk> <873a8iqqgv.fsf@devron.myhome.or.jp> <20090727142303.41096bf5@lxorguk.ukuu.org.uk> <877hxujkuv.fsf@devron.myhome.or.jp> <20090727145805.690afe5d@lxorguk.ukuu.org.uk> <87fxci6ub9.fsf@devron.myhome.or.jp> <20090727161424.GA4233@skywalker> <20090727174252.2d987830@lxorguk.ukuu.org.uk> <20090727171213.GB4233@skywalker> <87skgikjr8.fsf@devron.myhome.or.jp> <87ocr5dfpb.fsf@devron.myhome.or.jp> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 946 Lines: 26 On Tue, 28 Jul 2009, OGAWA Hirofumi wrote: > > > So at what point do we just admit that the commit that caused all this was > > a buggy pile of sh*t and just revert it? > > Also, I'm not sure though, I guess it depends on the bug which was fixed > by the commit. It doesn't really. The fact is, we don't accept "fix one bug, introduce another" code. We're much better off with _old_ bugs than with new ones. I'd love to have both the old and the new fixed, but I'm not seeing a lot of progress on this new bug, and at some point I'm going to have to decide to just revert the commit that caused this whole breakage, until a fix that doesn't cause new problems can be worked out. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/